You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fluid Block and specifies that the user should wrap HorizontalScroller in containers
Hi! Please look over the documentation and the demos carefully and make sure I haven't introduced any errors.
Please also look at the outstanding review comments in this #381. Namely, I still think the ScrollerBase example is odd -- would we ever want vertical captions with horizontal scroll? I'm fine keeping the demo since you've built it already, but in general, we should think about use cases when we build these demos. If there's too much demos/documentation, things can get lost, so there's a balance to strike there.
Notes
I got rid of snippets in HorizontalScroller.stories.svelte and set up each story in a way that more closely resembles the code blocks. There's nothing wrong with how you had it before with snippets, but setting them up this way makes it much easier for me to cross check the stories vs the code blocks in the .mdx file and make sure they match.
Please make sure the code blocks are copy-paste ready. Sometimes they don't match the story demos or they have the wrong variable/component names.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I kind of agree with you on the ScrollerBase story, but also want to highlight the handleScroll prop when progress is bound by another variable. I'll give it a try if I can come up with any other story that shows that.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MinamiFunakoshiTR
requested review from
SudevKiyadaTR
and removed request for
hobbes7878
What's in this pull request
Blockand specifies that the user should wrap HorizontalScroller in containersHi! Please look over the documentation and the demos carefully and make sure I haven't introduced any errors.
Please also look at the outstanding review comments in this #381. Namely, I still think the ScrollerBase example is odd -- would we ever want vertical captions with horizontal scroll? I'm fine keeping the demo since you've built it already, but in general, we should think about use cases when we build these demos. If there's too much demos/documentation, things can get lost, so there's a balance to strike there.
Notes
HorizontalScroller.stories.svelteand set up each story in a way that more closely resembles the code blocks. There's nothing wrong with how you had it before with snippets, but setting them up this way makes it much easier for me to cross check the stories vs the code blocks in the .mdx file and make sure they match.Thanks!